linux-kernel - Re: [PATCH] usb: uhci-platform: Make the clock really optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025042549-comma-whoever-ffe7@gregkh>
Date: Fri, 25 Apr 2025 16:20:33 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alexey Charkov <alchark@...il.com>
Cc: Alan Stern <stern@...land.harvard.edu>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] usb: uhci-platform: Make the clock really optional

On Fri, Apr 25, 2025 at 06:11:11PM +0400, Alexey Charkov wrote:
> Device tree bindings state that the clock is optional for UHCI platform
> controllers, and some existing device trees don't provide those - such
> as those for VIA/WonderMedia devices.
> 
> The driver however fails to probe now if no clock is provided, because
> devm_clk_get returns an error pointer in such case.
> 
> Switch to devm_clk_get_optional instead, so that it could probe again
> on those platforms where no clocks are given.
> 
> Cc: stable@...r.kernel.org
> Fixes: 26c502701c52 ("usb: uhci: Add clk support to uhci-platform")
> Signed-off-by: Alexey Charkov <alchark@...il.com>
> ---
>  drivers/usb/host/uhci-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index a7c934404ebc7ed74f64265fafa7830809979ba5..62318291f5664c9ec94f24535c71d962e28354f3 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -121,7 +121,7 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Get and enable clock if any specified */
> -	uhci->clk = devm_clk_get(&pdev->dev, NULL);
> +	uhci->clk = devm_clk_get_optional(&pdev->dev, NULL);

Why does this need to go to all stable trees all of a sudden?  This has
been "broken" for years, what changed recently to cause this to show up?

thanks,

greg k-h