linux-kernel - Re: [PATCH v1 01/10] dt-bindings: clock: Add RTC clock binding for Maxim MAX77686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34087c68-442f-41ec-a6c0-dd063f6d44d1@kernel.org>
Date: Fri, 25 Apr 2025 16:44:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Anand Moon <linux.amoon@...il.com>, Chanwoo Choi <cw00.choi@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 "open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO..."
 <linux-kernel@...r.kernel.org>,
 "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES"
 <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v1 01/10] dt-bindings: clock: Add RTC clock binding for
 Maxim MAX77686

On 25/04/2025 15:26, Anand Moon wrote:
> +
> +  The MAX77686 contains three 32.768khz crystal clock outputs that can
> +  be controlled (gated/ungated) over I2C. Clocks are defined as
> +  preprocessor macros in dt-bindings/clock/maxim,max77686.h.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - max77686-rtc

So you claim RTC is a clock, right? Did not even think that RTC has a
bit different meaning?

But regardless, this code make no sense and was never tested. It cannot
work.

It reminds me previous approaches with whatever patches you found in the
downstream...

Best regards,
Krzysztof