linux-kernel - Re: [PATCH next] KVM: x86: Check that the high 32bits are clear in kvm_arch_vcpu_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174559663411.890078.15043837914578345884.b4-ty@google.com>
Date: Fri, 25 Apr 2025 15:08:55 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>, 
	Dan Carpenter <dan.carpenter@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H. Peter Anvin" <hpa@...or.com>, Pankaj Gupta <pankaj.gupta@....com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] KVM: x86: Check that the high 32bits are clear in kvm_arch_vcpu_ioctl_run()

On Mon, 24 Mar 2025 13:51:28 +0300, Dan Carpenter wrote:
> The "kvm_run->kvm_valid_regs" and "kvm_run->kvm_dirty_regs" variables are
> u64 type.  We are only using the lowest 3 bits but we want to ensure that
> the users are not passing invalid bits so that we can use the remaining
> bits in the future.
> 
> However "sync_valid_fields" and kvm_sync_valid_fields() are u32 type so
> the check only ensures that the lower 32 bits are clear.  Fix this by
> changing the types to u64.
> 
> [...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: x86: Check that the high 32bits are clear in kvm_arch_vcpu_ioctl_run()
      commit: a476cadf8ef1fbb9780581316f0199dfc62a81f2

--
https://github.com/kvm-x86/linux/tree/next