linux-kernel - Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom sa8255p-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95c66338-87c0-4fce-866b-6c43c1d31cd1@quicinc.com>
Date: Thu, 24 Apr 2025 21:53:35 -0700
From: Deepti Jaggi <quic_djaggi@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <quic_psodagud@...cinc.com>
CC: <quic_ptalari@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Shazad Hussain
	<quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom
 sa8255p-ride



On 4/23/25 23:19, Krzysztof Kozlowski wrote:
> On 23/04/2025 01:12, Deepti Jaggi wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>> new file mode 100644
>> index 000000000000..cb866f897d0a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>> @@ -0,0 +1,94 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> +#include "sa8255p.dtsi"
>> +#include "sa8255p-pmics.dtsi"
>> +#include "sa8255p-scmi.dtsi"
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. SA8255P Ride";
>> +	compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
> 
> NAK
> 
> Missing bindings. This is some weird process you have there. Reach to
> your internal guideline before you start posting. It explains this.
> 

I followed the approach used for other bindings [1] [2] [3], 
which were part of the original series and were sent as separate patches 
and accepted. I misjudged that the SoC binding could also be sent as a 
separate patch. I will combine the remaining bindings along with 
the device tree into a single series.
 
The UART/QUP driver changes have been posted as a separate series [4] 
along with the UART bindings. Please advise if the UART/QUP bindings should
also be included as part of next series with dt changes.
 
[1]: https://lore.kernel.org/all/20240910165926.2408630-1-quic_nkela@quicinc.com/ 
[2]: https://lore.kernel.org/all/20240910171534.2412263-1-quic_nkela@quicinc.com/ 
[3]: https://lore.kernel.org/all/20240905194741.3803345-1-quic_nkela@quicinc.com/ 
[4]: https://lore.kernel.org/all/20250418151235.27787-2-quic_ptalari@quicinc.com/
 
> Best regards,
> Krzysztof

--Regards,
Deepti