linux-kernel - Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom sa8255p-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cf4302f-a4ba-41fb-bcef-0830013c5698@kernel.org>
Date: Fri, 25 Apr 2025 07:43:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Deepti Jaggi <quic_djaggi@...cinc.com>, andersson@...nel.org,
 konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, quic_psodagud@...cinc.com
Cc: quic_ptalari@...cinc.com, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shazad Hussain <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v3] arm64: dts: qcom: add initial support for qcom
 sa8255p-ride

On 25/04/2025 06:53, Deepti Jaggi wrote:
> 
> 
> On 4/23/25 23:19, Krzysztof Kozlowski wrote:
>> On 23/04/2025 01:12, Deepti Jaggi wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8255p-ride.dts b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>>> new file mode 100644
>>> index 000000000000..cb866f897d0a
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/sa8255p-ride.dts
>>> @@ -0,0 +1,94 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +
>>> +#include "sa8255p.dtsi"
>>> +#include "sa8255p-pmics.dtsi"
>>> +#include "sa8255p-scmi.dtsi"
>>> +
>>> +/ {
>>> +	model = "Qualcomm Technologies, Inc. SA8255P Ride";
>>> +	compatible = "qcom,sa8255p-ride", "qcom,sa8255p";
>>
>> NAK
>>
>> Missing bindings. This is some weird process you have there. Reach to
>> your internal guideline before you start posting. It explains this.
>>
> 
> I followed the approach used for other bindings [1] [2] [3], 
> which were part of the original series and were sent as separate patches 
> and accepted. I misjudged that the SoC binding could also be sent as a 
> separate patch. I will combine the remaining bindings along with 
> the device tree into a single series.
>  
> The UART/QUP driver changes have been posted as a separate series [4] 
> along with the UART bindings. Please advise if the UART/QUP bindings should
> also be included as part of next series with dt changes.

I think existing docs have it well covered and explained. I advise to
read all submitting patches documents.


Best regards,
Krzysztof