linux-kernel - Re: [PATCH v4 5/5] PCI: cadence: Add callback functions for RP and EP controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504251312.YvKIAjMl-lkp@intel.com>
Date: Fri, 25 Apr 2025 14:01:31 +0800
From: kernel test robot <lkp@...el.com>
To: hans.zhang@...tech.com, bhelgaas@...gle.com, lpieralisi@...nel.org,
	kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	peter.chen@...tech.com, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Manikandan K Pillai <mpillai@...ence.com>,
	Hans Zhang <hans.zhang@...tech.com>
Subject: Re: [PATCH v4 5/5] PCI: cadence: Add callback functions for RP and
 EP controller

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2]

url:    https://github.com/intel-lab-lkp/linux/commits/hans-zhang-cixtech-com/dt-bindings-pci-cadence-Extend-compatible-for-new-RP-configuration/20250424-090651
base:   fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2
patch link:    https://lore.kernel.org/r/20250424010445.2260090-6-hans.zhang%40cixtech.com
patch subject: [PATCH v4 5/5] PCI: cadence: Add callback functions for RP and EP controller
config: i386-buildonly-randconfig-003-20250425 (https://download.01.org/0day-ci/archive/20250425/202504251312.YvKIAjMl-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504251312.YvKIAjMl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504251312.YvKIAjMl-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/pci/controller/cadence/pcie-cadence-plat.c:13:
   drivers/pci/controller/cadence/pcie-cadence.h:851:8: error: expected ')'
     851 |                                                  int where)
         |                                                  ^
   drivers/pci/controller/cadence/pcie-cadence.h:850:49: note: to match this '('
     850 | static inline void __iomem *cdns_pci_hpa_map_bus(struct pci_bus *bus, unsigned int devfn
         |                                                 ^
>> drivers/pci/controller/cadence/pcie-cadence-plat.c:35:25: error: use of undeclared identifier 'cdns_pcie_host_init_root_port'; did you mean 'cdns_pcie_hpa_host_init_root_port'?
      35 |         .host_init_root_port = cdns_pcie_host_init_root_port,
         |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                cdns_pcie_hpa_host_init_root_port
   drivers/pci/controller/cadence/pcie-cadence.h:855:19: note: 'cdns_pcie_hpa_host_init_root_port' declared here
     855 | static inline int cdns_pcie_hpa_host_init_root_port(struct cdns_pcie_rc *rc)
         |                   ^
>> drivers/pci/controller/cadence/pcie-cadence-plat.c:36:24: error: use of undeclared identifier 'cdns_pcie_host_bar_ib_config'; did you mean 'cdns_pcie_hpa_host_bar_ib_config'?
      36 |         .host_bar_ib_config = cdns_pcie_host_bar_ib_config,
         |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                               cdns_pcie_hpa_host_bar_ib_config
   drivers/pci/controller/cadence/pcie-cadence.h:859:19: note: 'cdns_pcie_hpa_host_bar_ib_config' declared here
     859 | static inline int cdns_pcie_hpa_host_bar_ib_config(struct cdns_pcie_rc *rc,
         |                   ^
>> drivers/pci/controller/cadence/pcie-cadence-plat.c:37:35: error: use of undeclared identifier 'cdns_pcie_host_init_address_translation'; did you mean 'cdns_pcie_hpa_host_init_address_translation'?
      37 |         .host_init_address_translation = cdns_pcie_host_init_address_translation,
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                          cdns_pcie_hpa_host_init_address_translation
   drivers/pci/controller/cadence/pcie-cadence.h:866:19: note: 'cdns_pcie_hpa_host_init_address_translation' declared here
     866 | static inline int cdns_pcie_hpa_host_init_address_translation(struct cdns_pcie_rc *rc)
         |                   ^
   4 errors generated.


vim +35 drivers/pci/controller/cadence/pcie-cadence-plat.c

    31	
    32	static const struct cdns_pcie_ops cdns_plat_ops = {
    33		.link_up = cdns_pcie_linkup,
    34		.cpu_addr_fixup = cdns_plat_cpu_addr_fixup,
  > 35		.host_init_root_port = cdns_pcie_host_init_root_port,
  > 36		.host_bar_ib_config = cdns_pcie_host_bar_ib_config,
  > 37		.host_init_address_translation = cdns_pcie_host_init_address_translation,
    38		.detect_quiet_min_delay_set = cdns_pcie_detect_quiet_min_delay_set,
    39		.set_outbound_region = cdns_pcie_set_outbound_region,
    40		.set_outbound_region_for_normal_msg =
    41						    cdns_pcie_set_outbound_region_for_normal_msg,
    42		.reset_outbound_region = cdns_pcie_reset_outbound_region,
    43	};
    44	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki