linux-kernel - Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <934c275b-1ea8-4a09-b2cb-6c9bca2860f3@icloud.com>
Date: Fri, 25 Apr 2025 19:36:42 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Rob Herring <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2 2/2] serdev: Remove repeated device name in
 dev_(err|dbg) messages

On 2025/4/25 02:34, Rob Herring wrote:
>> @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
>>                 goto err_rpm_disable;
>>         }
>>
>> -       dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
>> -               dev_name(&ctrl->dev), &ctrl->dev);
> I don't understand why you add dev_name() and then turn around and
> remove it in the next patch. Just squash the patches.

okay, will do it in next revision.