linux-kernel - Re: [PATCH v2 2/2] serdev: Remove repeated device name in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05d1f626-1c76-4b78-9028-f31d42f4d528@icloud.com>
Date: Fri, 25 Apr 2025 19:37:45 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2 2/2] serdev: Remove repeated device name in
 dev_(err|dbg) messages

On 2025/4/25 13:38, Jiri Slaby wrote:
>>
>> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
>> index
>> 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
>> --- a/drivers/tty/serdev/core.c
>> +++ b/drivers/tty/serdev/core.c
>> @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)
>>         err = device_add(&serdev->dev);
>>       if (err < 0) {
>> -        dev_err(&serdev->dev, "Can't add %s, status %pe\n",
>> -            dev_name(&serdev->dev), ERR_PTR(err));
>> +        dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
>> +            ERR_PTR(err));
> 
> You don't need to wrap now.
> 
> Could you also get rid of ERR_PTR() and print err directly using %d?
> 
>>           goto err_clear_serdev; 

sure, will do it in next revision.