linux-kernel - Re: [PATCH v7 0/5] leds: add new LED driver for TI LP5812

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250426101942.10233-1-trannamatk@gmail.com>
Date: Sat, 26 Apr 2025 17:19:42 +0700
From: Nam Tran <trannamatk@...il.com>
To: lee@...nel.org
Cc: christophe.jaillet@...adoo.fr,
	pavel@...nel.org,
	krzk+dt@...nel.org,
	robh@...nel.org,
	conor+dt@...nel.org,
	corbet@....net,
	devicetree@...r.kernel.org,
	linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 0/5] leds: add new LED driver for TI LP5812

On Fri, 25 Apr 2025, Lee Jones wrote:

> On Wed, 23 Apr 2025, Nam Tran wrote:
> 
> > This patch series adds support for the TI/National Semiconductor LP5812
> > 4x3 matrix RGB LED driver. The driver supports features such as autonomous
> > animation and time-cross-multiplexing (TCM) for dynamic LED effects.
> > 
> > Signed-off-by: Nam Tran <trannamatk@...il.com>
> > ---
> > Changes in v7:
> > - Mark `chip_leds_map` as const.
> > - Use consistent `ret` initialization.
> > - Simplify the function `set_mix_sel_led()`.
> > - Refactor `dev_config_show()` and `led_auto_animation_show()` to avoid temp buffer, malloc/free.
> > - Simplify the code and ensure consistent use of mutex lock/unlock in show/store functions.
> > - Remove `total_leds` and `total_aeu`.
> > - Link to v6: https://lore.kernel.org/linux-leds/20250419184333.56617-1-trannamatk@gmail.com/
> > 
> > Changes in v6:
> > - Add `vcc-supply` property to describe the LP5812 power supply.
> > - Remove `chan-name` property and entire LED subnodes, as they are not needed.
> > - Update LP5812 LED driver node to Raspberry Pi 4 B Device Tree, based on updated binding.
> > - Link to v5: https://lore.kernel.org/linux-leds/20250414145742.35713-1-trannamatk@gmail.com/
> > 
> > Changes in v5:
> > - Rebase on v6.15-rc2
> > - Removed unused functions (lp5812_dump_regs, lp5812_update_bit).
> > - Address Krzysztof's review comments
> > - Link to v4: https://lore.kernel.org/linux-leds/20250405183246.198568-1-trannamatk@gmail.com/
> > ---
> > 
> > Nam Tran (5):
> >   dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver
> >   leds: add TI/National Semiconductor LP5812 LED Driver
> >   docs: ABI: Document LP5812 LED sysfs interfaces
> >   docs: leds: Document TI LP5812 LED driver
> >   arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
> > 
> >  .../ABI/testing/sysfs-bus-i2c-devices-lp5812  |  144 +
> >  .../devicetree/bindings/leds/ti,lp5812.yaml   |   46 +
> >  Documentation/leds/leds-lp5812.rst            |   79 +
> >  MAINTAINERS                                   |   12 +
> >  .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts |   10 +
> >  drivers/leds/Kconfig                          |   16 +
> >  drivers/leds/Makefile                         |    1 +
> >  drivers/leds/leds-lp5812.c                    | 2736 +++++++++++++++++
> >  drivers/leds/leds-lp5812.h                    |  348 +++
> >  9 files changed, 3392 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-lp5812
> >  create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml
> >  create mode 100644 Documentation/leds/leds-lp5812.rst
> >  create mode 100644 drivers/leds/leds-lp5812.c
> >  create mode 100644 drivers/leds/leds-lp5812.h
> 
> Nothing about this driver has anything to do with the LEDs subsystem.
> 
> Suggest moving it to drivers/auxdisplay instead.

Thank you for the feedback.

I'll move the driver to drivers/auxdisplay as you suggested
and will prepare a new version accordingly.

Best regards,
Nam Tran