linux-kernel - Re: [PATCH 0/3] MCP3911 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250426163556.53310ed2@jic23-huawei>
Date: Sat, 26 Apr 2025 16:35:56 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Kent Gustavsson <kent@...oris.se>, Lars-Peter Clausen <lars@...afoo.de>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Kent Gustavsson
 <nedo80@...il.com>, devicetree@...r.kernel.org, Lukas Rauber
 <lukas.rauber@...itza.de>
Subject: Re: [PATCH 0/3] MCP3911 fixes

On Wed, 23 Apr 2025 16:46:48 +0200
Marcus Folkesson <marcus.folkesson@...il.com> wrote:

> This series contain two fixes for the MCP3911 driver:
> - Add support for reset signal
> - Fix wrong mapping for the coversion result registers
> 
> The register map for the conversion result registers of the MCP3911
> differs from the other variants so make sure we read from the right
> register by introducing device-dependent .read_raw() callbacks.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
I took a quick look as well. Nothing to add to Andy's detailed review
so I'll wait for v2.