linux-kernel - Re: [PATCH 2/2] Staging: media: atomisp: style corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vef0DuupHr9CAaU9qnDEw6O6KRPaO51uzrKXPwvfAiiJA@mail.gmail.com>
Date: Sun, 27 Apr 2025 12:41:34 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Andreatta <thomasandreatta2000@...il.com>
Cc: andy@...nel.org, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Thomas Andreatta <thomas.andreatta2000@...il.com>
Subject: Re: [PATCH 2/2] Staging: media: atomisp: style corrections

On Sat, Apr 26, 2025 at 11:15 PM Thomas Andreatta
<thomasandreatta2000@...il.com> wrote:
>
> Corrected consistent spacing around '*' and braces positions

Missed period.
And what is the correct spacing and why?

...

>  static unsigned int get_crop_lines_for_bayer_order(const struct
> -       ia_css_stream_config *config);
> +       ia_css_stream_config * config);
>  static unsigned int get_crop_columns_for_bayer_order(const struct
> -       ia_css_stream_config *config);
> +       ia_css_stream_config * config);

No, this makes it the opposite. Please, read Coding Style if it sheds
a light on this. In any case the kernel style is to avoid spacing
between asterisk and name.

-- 
With Best Regards,
Andy Shevchenko