linux-kernel - Re: [PATCH 2/2] Staging: media: atomisp: style corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250427142422.88271-1-thomas.andreatta2000@gmail.com>
Date: Sun, 27 Apr 2025 16:24:22 +0200
From: Thomas Andreatta <thomasandreatta2000@...il.com>
To: andy@...nel.org
Cc: linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	thomas.andreatta2000@...il.com
Subject: Re: [PATCH 2/2] Staging: media: atomisp: style corrections

On Sun, Apr 27, 2025 at 12:41:34PM +0300, Andy Shevchenko wrote:
> On Sat, Apr 26, 2025 at 11:15 PM Thomas Andreatta
> <thomasandreatta2000@...il.com> wrote:
> >
> > Corrected consistent spacing around '*' and braces positions
> 
> Missed period.
> And what is the correct spacing and why?

I agree that the spacing looks weird and I questioned it too, but the script
checkpatch.pl highlights as error:
`sh_css.c:336: ERROR: need consistent spacing around '*' (ctx:WxV)`
`sh_css.c:338: ERROR: need consistent spacing around '*' (ctx:WxV)`

Should this be ignored because the script tries its best and it becomes common
sense that the suggested spacing is "wrong"?

> 
> ...
> 
> >  static unsigned int get_crop_lines_for_bayer_order(const struct
> > -       ia_css_stream_config *config);
> > +       ia_css_stream_config * config);
> >  static unsigned int get_crop_columns_for_bayer_order(const struct
> > -       ia_css_stream_config *config);
> > +       ia_css_stream_config * config);
> 
> No, this makes it the opposite. Please, read Coding Style if it sheds
> a light on this. In any case the kernel style is to avoid spacing
> between asterisk and name.

Understood. I'll resubmit with the correct spacing.

Thanks,
Thomas