linux-kernel - Re: [PATCH 0/5] Regulator deadcode cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aA5F-_kJO0jFgKpQ@gallifrey>
Date: Sun, 27 Apr 2025 14:58:03 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Mark Brown <broonie@...nel.org>
Cc: lgirdwood@...il.com, linux-doc@...r.kernel.org, corbet@....net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Regulator deadcode cleanups

* Mark Brown (broonie@...nel.org) wrote:
> On Sat, Apr 26, 2025 at 06:51:38PM +0100, linux@...blig.org wrote:
> 
> >   This is a bunch of deadcode cleanups for functions
> > that are unused (for quite some time).
> >   The first patch was originally sent in October last
> > year but didn't get any traction; the rest are new.
> 
> Please do some analysis as to why the functions are there, don't just
> blindly delete things.

I'd appreciate some more idea of what you're after;  each patch
shows where and when the function was added or last used.  Some have
comments saying things like the devm_ version is being used (so it
seemed reasonable to me to delete the plain version if no one uses it).

For each one I've checked _when_ it was last used and not deleted
anything that's been used in the last few years; I've not deleted
anything which has been recently added or only recently unused.

That level seems to have been fine on the other ~300 clean up 
patches other maintainers have taken; you seem to be after something
different - I'm fine to add that if you can just explain what
you want.

Just point me in the right direction and I can have more of a dig.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/