linux-kernel - Re: [PATCH 0/5] Regulator deadcode cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBKvw3KEikfdQbn7@finisterre.sirena.org.uk>
Date: Thu, 1 May 2025 08:18:27 +0900
From: Mark Brown <broonie@...nel.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: lgirdwood@...il.com, linux-doc@...r.kernel.org, corbet@....net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Regulator deadcode cleanups

On Sun, Apr 27, 2025 at 02:58:03PM +0000, Dr. David Alan Gilbert wrote:
> * Mark Brown (broonie@...nel.org) wrote:

> > Please do some analysis as to why the functions are there, don't just
> > blindly delete things.

> I'd appreciate some more idea of what you're after;  each patch
> shows where and when the function was added or last used.  Some have

Something that indicates that this is a patch written by a human rather
than some automated noise, that considers things like API usability and
coherence, or what people might do if the API is not available when they
need it, rather than just mechanically churning something out.  None of
your commit logs consider what the code you're deleting does at all.

> comments saying things like the devm_ version is being used (so it
> seemed reasonable to me to delete the plain version if no one uses it).

Deleting the plain version of something where a devm version exists is
an obvious example of making the API less coherent and hard to use,
managed resources aren't universally appropriate and so you should
generally be able to do the same thing with manual resource management.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)