linux-kernel - Re: [PATCH] pds_core: Allocate pdsc_viftype_defaults copy with ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b18129cd-18a4-40b3-94cc-0228f0e04d2a@amd.com>
Date: Mon, 28 Apr 2025 09:05:26 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Kees Cook <kees@...nel.org>
Cc: Brett Creeley <brett.creeley@....com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] pds_core: Allocate pdsc_viftype_defaults copy with
 ARRAY_SIZE()

On 4/25/2025 11:07 PM, Kees Cook wrote:
> 
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> This is allocating a copy of pdsc_viftype_defaults, which is an array of
> struct pdsc_viftype. To correctly return "struct pdsc_viftype *" in the
> future, adjust the allocation to allocating ARRAY_SIZE-many entries. The
> resulting allocation size is the same.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>

Thanks,
sln

Reviewed-by: Shannon Nelson <shannon.nelson@....com>

> ---
> Cc: Shannon Nelson <shannon.nelson@....com>
> Cc: Brett Creeley <brett.creeley@....com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: <netdev@...r.kernel.org>
> ---
>   drivers/net/ethernet/amd/pds_core/core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/ethernet/amd/pds_core/core.c
> index 1eb0d92786f7..451b005d48d0 100644
> --- a/drivers/net/ethernet/amd/pds_core/core.c
> +++ b/drivers/net/ethernet/amd/pds_core/core.c
> @@ -415,7 +415,8 @@ static int pdsc_viftypes_init(struct pdsc *pdsc)
>   {
>          enum pds_core_vif_types vt;
> 
> -       pdsc->viftype_status = kzalloc(sizeof(pdsc_viftype_defaults),
> +       pdsc->viftype_status = kcalloc(ARRAY_SIZE(pdsc_viftype_defaults),
> +                                      sizeof(*pdsc->viftype_status),
>                                         GFP_KERNEL);
>          if (!pdsc->viftype_status)
>                  return -ENOMEM;
> --
> 2.34.1
>