linux-kernel - Re: [PATCH v2] iio: frequency: ad9832: devicetree probing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250428160631.GA1353496-robh@kernel.org>
Date: Mon, 28 Apr 2025 11:06:31 -0500
From: Rob Herring <robh@...nel.org>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Siddharth Menon <simeddon@...il.com>, linux-iio@...r.kernel.org,
	lars@...afoo.de, Michael.Hennerich@...log.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v2] iio: frequency: ad9832: devicetree probing support

On Fri, Apr 18, 2025 at 03:26:21PM +0100, Jonathan Cameron wrote:
> On Wed, 16 Apr 2025 13:58:46 -0500
> Rob Herring <robh@...nel.org> wrote:
> 
> > On Sat, Mar 22, 2025 at 09:58:11PM +0530, Siddharth Menon wrote:
> > > Introduce struct for device match of_device_id to avoid relying on fallback
> > > mechanisms, which could lead to false matches against other AD9832 variants
> > > in the future.
> > > 
> > > Suggested-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> > > Signed-off-by: Siddharth Menon <simeddon@...il.com>
> > > ---
> > >  v1->v2:
> > >  - updated commit message to be more informative
> > >  - minor changes to code formatting
> > >  drivers/staging/iio/frequency/ad9832.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> > > index 140ee4f9c137..7d4f655f6df1 100644
> > > --- a/drivers/staging/iio/frequency/ad9832.c
> > > +++ b/drivers/staging/iio/frequency/ad9832.c
> > > @@ -431,6 +431,13 @@ static int ad9832_probe(struct spi_device *spi)
> > >  	return devm_iio_device_register(&spi->dev, indio_dev);
> > >  }
> > >  
> > > +static const struct of_device_id ad9832_of_match[] = {
> > > +	{ .compatible = "adi,ad9832" },
> > > +	{ .compatible = "adi,ad9835" },  
> > 
> > Is there some reason we can't add a binding for this?
> > 
> It might take some thought on how to actually describe some aspects
> of this device that aren't yet supported by the driver,
> but in principle we certainly should.  For drivers that have been
> in staging a long time I'm a little reluctant to do merge a binding
> until we are fairly sure the driver is going to move out of staging though.

Okay, I suppose I could exclude staging from looking for compatible 
strings.

Rob