linux-kernel - Re: [PATCH v2 3/6] riscv: dts: spacemit: add PWM support for K1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <t4tnrsyl7t7hwfm752eapz3ajxkkl23nrfemw4jy6a7khi7a7u@gow3c2ba56ib>
Date: Mon, 28 Apr 2025 18:32:37 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr, 
	dlan@...too.org, p.zabel@...gutronix.de, drew@...7.com, inochiama@...il.com, 
	geert+renesas@...der.be, heylenay@....org, tglx@...utronix.de, hal.feng@...rfivetech.com, 
	unicorn_wang@...look.com, duje.mihanovic@...le.hr, elder@...cstar.com, 
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev
Subject: Re: [PATCH v2 3/6] riscv: dts: spacemit: add PWM support for K1 SoC

Hello,

On Mon, Apr 28, 2025 at 08:46:50PM +0800, Guodong Xu wrote:
> On Thu, Apr 24, 2025 at 4:18 PM Uwe Kleine-König <ukleinek@...nel.org> wrote:
> > I want to make all pwms use #pwm-cells = <3> in the long run. Can you
> 
> Sure. I can do this.
> 
> > please use that for the new binding? (Of course this needs adaption in
> > the binding doc, the code should already be prepared for that.)
> >
> 
> I got what you mean. The code change for that is already integrated into
> v6.15-rc1.
> Commit 895fe4537cc8 ("pwm: Add upgrade path to #pwm-cells = <3> for users of
> of_pwm_single_xlate()")
> 
> Now, if I change this #pwm-cells from <1> to <3>, without the dt-binding doc
> changes, I would expect to see warnings (" #pwm-cells: 1 was expected") during
>   make dtbs_check W=3
> 
> Any suggestions when the dt-binding changes will be merged?
> or I can add your patch as a dependency.
> https://lore.kernel.org/all/cb799d8a5bb284cd861785a691b8d5e329300d99.1738842938.git.u.kleine-koenig@baylibre.com/

I don't want to merge this very soon given that 895fe4537cc8 isn't that
old yet. But I suggest you adapt patch #1 to require #pwm-cells = <3>
for the newly added compatible.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)