linux-kernel - Re: [PATCH v2] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCk7NqLQdpbvdknEHEB0NNU7OPhmmHkH3Q4PCYiOzf2fBQBkw@mail.gmail.com>
Date: Mon, 28 Apr 2025 11:48:39 -0600
From: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: msm8998-lenovo-miix-630: add Venus node

On Mon, Apr 28, 2025 at 10:21 AM Dmitry Baryshkov
<dmitry.baryshkov@....qualcomm.com> wrote:
>
> On Mon, Apr 28, 2025 at 09:40:52AM -0600, Jeffrey Hugo wrote:
> > On Fri, Apr 25, 2025 at 12:28 PM Dmitry Baryshkov
> > <dmitry.baryshkov@....qualcomm.com> wrote:
> > >
> > > Enable Venus on Lenovo Miix 630 and specify corresponding firmware file.
> >
> > I'm curious, how did this get validated?  I didn't think there was
> > enough infrastructure enabled on this platform to check that the
> > lights were even on on in Venus.
>
> I must admit, I basically checked that the firmware starts up. Marc
> Gonzalez worked on enablement of Venus on MSM8998 (on the freebox), so I
> didn't perform a thorough check.

If you got the FW starting up, that is farther than I expected.  I
must be wrong about the capabilities then.
The DT node looks right to me.

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>

>
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> > > ---
> > > Changes in v2:
> > > - Rebasde on top of linux-next
> > > - Link to v1: https://lore.kernel.org/r/20250408-miix-630-venus-v1-1-771c330ee279@oss.qualcomm.com
> > > ---
> > >  arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
>
> --
> With best wishes
> Dmitry