linux-kernel - Re: [PATCH] iio: ti-adc128s052: Drop variable vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcUcrj-BLp9QDsYMDY_SeQS76LDGge5vVqrx-MVwukP0w@mail.gmail.com>
Date: Mon, 28 Apr 2025 10:08:32 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: ti-adc128s052: Drop variable vref

On Mon, Apr 28, 2025 at 10:02 AM Matti Vaittinen
<mazziesaccount@...il.com> wrote:
>
> According to Jonathan, variable reference voltages are very rare. It is
> unlikely it is needed, and supporting it makes the code a bit more
> complex.
>
> Simplify the driver and drop the variable vref support.

...

> +       int vref_mv;

vref_mV please. And yes, I know historical and other reasons for them
all being small, but let's try to be more scientific in these crazy
days.

...

> +       adc->vref_mv = ret / 1000;

MILLI ?
Or actually a time to introduce MILLIVOLT_PER_VOLT in units.h ?

-- 
With Best Regards,
Andy Shevchenko