linux-kernel - Re: [PATCH] media: dt-bindings: Add OminiVision 0V02C10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aA8uN5Y4MuqR-p7H@kekkonen.localdomain>
Date: Mon, 28 Apr 2025 07:28:55 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Bryan O'Donoghue <bod@...nel.org>, Hans de Goede <hansg@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: Add OminiVision 0V02C10

Hi Bryan,

Thanks for the patch.

On Sat, Apr 26, 2025 at 11:35:21PM +0100, Bryan O'Donoghue wrote:
> Extend the ov02e10 bindings yaml to describe the ov02c10 sensor which has
> the same bindings with a different compat string and different i2c
> address only.
> 
> Other differences in sensor capabilities exist but are not expressed in
> devicetree.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> I previously submitted a standalone ov02c10 yaml file but, it was pointed
> out to me by Krzysztof that the ov02e10 yaml has exactly the same bindings
> and we should therefore extend the ov02e10 yaml.
> 
> Link: https://lore.kernel.org/linux-media/da93bf6c-b4bc-4c4f-9373-583fbd0c031c@kernel.org/
> 
> The accompanying patch:
> 
> - Updates the overall description to differentiate between the two sensors
> - Adds ovti,ov02c10 compat string
> - Adds an example for the ov02c10
> 
> Once merged we can also merge the ov02c10 driver, which contains a compat
> string requiring yaml description as precursor to merge.
> ---
>  .../bindings/media/i2c/ovti,ov02e10.yaml           | 47 ++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml
> index 4ac4e11a16c8bb7a53db0c44289b1004dbdc282a..1561a3e96caa8b09a4c105b87536bb0d00b2adf8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml
> @@ -11,12 +11,22 @@ maintainers:
>    - Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>  
>  description: |
> -  The Omnivision OV02E10 is a 2 megapixel, CMOS image sensor which supports:
> +  The Omnivision OV02E10 and 0V02C10 sensors are 2 megapixel, CMOS image sensors which support:
>    - Automatic black level calibration (ABLC)
>    - Programmable controls for frame rate, mirror and flip, binning, cropping
>      and windowing
> -  - Output formats 10-bit 4C RGB RAW, 10-bit Bayer RAW
> -  - 2-lane MIPI D-PHY TX @ 720 Mbps per lane
> +  - OVO2C10
> +    - 10 bit 1920x1080 60 fps 2-lane @ 800 Mbps/lane
> +    - 10 bit 1920x1080 60 fps 1-lane @ 1500 Mbps/lane
> +    - 10 bit 1280x720 60 fps cropped 1-lane @ 960 Mbps/lane
> +    - 10 bit RGB/BW 640x480 60 fps bin2 or skip2 1-lane @ 800 Mbps/lane
> +    - 10 bit RGB/BW 480x270 60 fps bin4 or skip4 1-lane @ 800 Mbps/lane
> +  - OV02E10
> +    - 10 bit 1920x1088 60 fps 2-lane @ 720 Mbps/lane
> +    - 10 bit 1280x1080 60 fps 2-lane @ 720 Mbps/lane
> +    - 10 bit 960x540 60 fps 2-lane 4c1 360 Mbps/lane
> +    - 8 bit 480x270 1/3/5/10 fps 4c1 sub2 288 Mbps/lane
> +    - 8 bit 232x132 1/3/5/10 fps 4c1 sub4 144 Mbps/lane

These look like driver features rather than hardware properties. What are
the hardware differences of the two sensors that could be listed here?

The earlier description also said this is 4C which I understand is
Omnivision term for quad Bayer pattern. It'd be nice to refer to that, too.
(I'd use quad Bayer instead in fact.)

-- 
Regards,

Sakari Ailus