linux-kernel - Re: [PATCH] media: dt-bindings: Add OminiVision 0V02C10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428-spry-mustard-flamingo-78ef4d@kuoka>
Date: Mon, 28 Apr 2025 10:38:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Bryan O'Donoghue <bod@...nel.org>, Hans de Goede <hansg@...nel.org>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: Add OminiVision 0V02C10

On Sat, Apr 26, 2025 at 11:35:21PM GMT, Bryan O'Donoghue wrote:
> Extend the ov02e10 bindings yaml to describe the ov02c10 sensor which has
> the same bindings with a different compat string and different i2c
> address only.
> 
> Other differences in sensor capabilities exist but are not expressed in
> devicetree.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> I previously submitted a standalone ov02c10 yaml file but, it was pointed
> out to me by Krzysztof that the ov02e10 yaml has exactly the same bindings
> and we should therefore extend the ov02e10 yaml.
> 
> Link: https://lore.kernel.org/linux-media/da93bf6c-b4bc-4c4f-9373-583fbd0c031c@kernel.org/
> 
> The accompanying patch:
> 
> - Updates the overall description to differentiate between the two sensors
> - Adds ovti,ov02c10 compat string
> - Adds an example for the ov02c10
> 
> Once merged we can also merge the ov02c10 driver, which contains a compat
> string requiring yaml description as precursor to merge.
> ---
>  .../bindings/media/i2c/ovti,ov02e10.yaml           | 47 ++++++++++++++++++++--
>  1 file changed, 43 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02e10.yaml

There is no such file in recent next (0424) and no dependencies
mentioned, so I cannot verify and I just assume that below:

> +        ov02c10: camera@36 {

makes sense and you are not duplicating I2C address on the same bus.

You should document the dependencies.

Best regards,
Krzysztof