| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c94409d9-3bd1-42c3-b5f6-785e994baa77@whut.edu.cn>
Date: Mon, 28 Apr 2025 17:44:46 +0800
From: Ze Huang <huangze@...t.edu.cn>
To: Yao Zi <ziyao@...root.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
<palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
Alexandre Ghiti <alex@...ti.fr>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: add usb3.0 support for K1
On 4/28/25 4:24 PM, Yao Zi wrote:
> On Mon, Apr 28, 2025 at 03:38:12PM +0800, Ze Huang wrote:
>> Add USB 3.0 support for the SpacemiT K1 SoC, including the
>> following components:
>>
>> - USB 2.0 PHY nodes
>> - USB 3.0 combo PHY node
>> - USB 3.0 host controller
>> - USB 3.0 hub and vbus regulator (usb3_vhub, usb3_vbus)
>> - DRAM interconnect node for USB DMA ("dma-mem")
>>
>> The `usb3_vbus` and `usb3_vhub` regulator node provides a fixed 5V
>> supply to power the onboard USB 3.0 hub and usb vbus.
>>
>> On K1, some DMA transfers from devices to memory use separate buses with
>> different DMA address translation rules from the parent node. We express
>> this relationship through the interconnects node("dma-mem").
>>
>> Signed-off-by: Ze Huang <huangze@...t.edu.cn>
>> ---
>> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 52 +++++++++++++++++++++++
>> arch/riscv/boot/dts/spacemit/k1.dtsi | 56 +++++++++++++++++++++++++
>> 2 files changed, 108 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
>> index 816ef1bc358ec490aff184d5915d680dbd9f00cb..0c0bf572d31e056955eb2ff377c3262271dcc156 100644
>> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
>> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
>> @@ -28,6 +28,25 @@ led1 {
>> default-state = "on";
>> };
>> };
>> +
>> + usb3_vhub: regulator-vhub-5v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "USB30_VHUB";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + };
>> +
>> + usb3_vbus: regulator-vbus-5v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "USB30_VBUS";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + regulator-always-on;
>> + gpio = <&gpio K1_GPIO(97) GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + };
>> };
>>
>> &uart0 {
>> @@ -35,3 +54,36 @@ &uart0 {
>> pinctrl-0 = <&uart0_2_cfg>;
>> status = "okay";
>> };
>> +
>> +&usbphy2 {
>> + status = "okay";
>> +};
>> +
>> +&combphy {
>> + status = "okay";
>> +};
>> +
>> +&usb_dwc3 {
>> + dr_mode = "host";
>> + phy_type = "utmi";
>> + snps,hsphy_interface = "utmi";
>> + snps,dis_enblslpm_quirk;
>> + snps,dis-u1u2-quirk;
>> + snps,dis-u2-freeclk-exists-quirk;
>> + snps,dis-del-phy-power-chg-quirk;
>> + snps,dis_u2_susphy_quirk;
>> + snps,dis_u3_susphy_quirk;
>> + snps,dis_rxdet_inp3_quirk;
>> + snps,xhci-trb-ent-quirk;
> I suspect whether it's the correct place to put these quirks: they look
> like IP quirks which are present in every K1 SoC regardless of the
> board model, if my understanding is correct they should go into SoC
> devicetree.
I checked these quirks in differenct board dts in vendor repo, they are
actually the same.
Will follow.
>
>> + vbus-supply = <&usb3_vbus>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + hub@1 {
>> + compatible = "usb2109,817";
>> + reg = <0x1>;
>> + vdd-supply = <&usb3_vhub>;
>> + reset-gpios = <&gpio K1_GPIO(124) GPIO_ACTIVE_LOW>;
>> + };
>> +};
>> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
>> index c0cc4b99c9356d550a470291dba9f2625b10f8df..c7b86c850da969e5412ad42c63995cd20b4d0484 100644
>> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
>> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
>> @@ -4,6 +4,8 @@
>> */
>>
>> #include <dt-bindings/clock/spacemit,k1-syscon.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/phy/phy.h>
>>
>> /dts-v1/;
>> / {
>> @@ -346,6 +348,13 @@ soc {
>> dma-noncoherent;
>> ranges;
>>
>> + dram_range0: dram-range@0 {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>;
>> + #interconnect-cells = <0>;
>> + };
>> +
>> syscon_rcpu: system-controller@...80000 {
>> compatible = "spacemit,k1-syscon-rcpu";
>> reg = <0x0 0xc0880000 0x0 0x2048>;
>> @@ -358,6 +367,53 @@ syscon_rcpu2: system-controller@...88000 {
>> #reset-cells = <1>;
>> };
>>
>> + usb_dwc3: usb@...00000 {
>> + compatible = "spacemit,k1-dwc3", "snps,dwc3";
>> + reg = <0x0 0xc0a00000 0x0 0x10000>;
>> + clocks = <&syscon_apmu CLK_USB30>;
>> + clock-names = "bus_early";
>> + resets = <&syscon_apmu RESET_USB3_0>;
>> + interrupt-parent = <&plic>;
>> + interrupts = <125>;
>> + interconnects = <&dram_range0>;
>> + interconnect-names = "dma-mem";
>> + phys = <&usbphy2>, <&combphy PHY_TYPE_USB3>;
>> + phy-names = "usb2-phy", "usb3-phy";
>> + status = "disabled";
>> + };
>> +
>> + usbphy0: phy@...40000 {
>> + compatible = "spacemit,usb2-phy";
>> + reg = <0x0 0xc0940000 0x0 0x200>;
>> + clocks = <&syscon_apmu CLK_USB_AXI>;
>> + status = "disabled";
>> + };
>> +
>> + usbphy1: phy@...c0000 {
>> + compatible = "spacemit,usb2-phy";
>> + reg = <0x0 0xc09c0000 0x0 0x200>;
>> + clocks = <&syscon_apmu CLK_USB_P1>;
>> + status = "disabled";
>> + };
> Why don't add #phy-cells properties to usbphy{0,1} just like usbphy2?
> You've claimed #phy-cells as an essential property of
> spacemit,k1-usb2-phy nodes in the PHY series and I suspect whether this
> passes dtbs_check.
The DT bindings for the USB PHY were submitted in an earlier patchset,
some dts checks about PHY were missed.
I will add #phy-cells in next version. thanks!
>
>> + usbphy2: phy@...0a30000 {
>> + compatible = "spacemit,k1-usb2-phy";
>> + reg = <0x0 0xc0a30000 0x0 0x200>;
>> + clocks = <&syscon_apmu CLK_USB30>;
>> + #phy-cells = <0>;
>> + status = "disabled";
>> + };
>> +
>> + combphy: phy@...10000 {
>> + compatible = "spacemit,k1-combphy";
>> + reg = <0x0 0xc0b10000 0x0 0x800>,
>> + <0x0 0xd4282910 0x0 0x400>;
>> + reg-names = "ctrl", "sel";
>> + resets = <&syscon_apmu RESET_PCIE0>;
>> + #phy-cells = <1>;
>> + status = "disabled";
>> + };
>> +
>> syscon_apbc: system-control@...15000 {
>> compatible = "spacemit,k1-syscon-apbc";
>> reg = <0x0 0xd4015000 0x0 0x1000>;
>>
>> --
>> 2.49.0
>>
>>
> Best regards,
> Yao Zi
>
>
>
Powered by blists - more mailing lists