linux-kernel - Re: [RESEND ath-next 1/2] dt-bindings: net: wireless: ath12k: describe firmware-name property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfd1be89-cb03-4426-ad7e-93b6774a68a7@quicinc.com>
Date: Mon, 28 Apr 2025 17:48:23 +0800
From: Miaoqing Pan <quic_miaoqing@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <jjohnson@...nel.org>, <johannes@...solutions.net>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <ath12k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [RESEND ath-next 1/2] dt-bindings: net: wireless: ath12k:
 describe firmware-name property



On 4/28/2025 4:25 PM, Krzysztof Kozlowski wrote:
> On Thu, Apr 24, 2025 at 08:57:02AM GMT, Miaoqing Pan wrote:
>> Introduce 'firmware-name' property to allow end-users and/or integrators
>> to decide which usecase-specific firmware to run on the WCN7850 platform.
>> This is necessary due to resource limitations such as memory capacity and
>> CPU capability, or performance and power optimization for different
>> application scenarios.
>>
>> Two firmwares are supported: 'WCN7850/hw2.0' and 'WCN7850/hw2.0/ncm825'.
>> The former is the default firmware, suitable for most WiFi 7 STA
>> functions. The latter adds support for commercial-quality SAP and
>> optimizes power consumption for IoT applications.
>>
>> Signed-off-by: Miaoqing Pan <quic_miaoqing@...cinc.com>
>> ---
>>   .../devicetree/bindings/net/wireless/qcom,ath12k.yaml       | 6 ++++++
>>   1 file changed, 6 insertions(+)
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 

I don't find any tags on previous version: 
https://patchwork.kernel.org/project/linux-wireless/patch/20250423054152.2471568-2-quic_miaoqing@quicinc.com/.

Do you mean I should add 'Reviewed-by: Krzysztof Kozlowski 
<krzk@...nel.org>' ?


> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions of patchset, under or above your Signed-off-by tag, unless
> patch changed significantly (e.g. new properties added to the DT
> bindings). Tag is "received", when provided in a message replied to you
> on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags. The upstream maintainer
> will do that for tags received on the version they apply.
> 
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Best regards,
> Krzysztof
>