linux-kernel - Re: [PATCH v7 1/2] MIPS: Fix idle VS timer enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2504280224110.31828@angie.orcam.me.uk>
Date: Mon, 28 Apr 2025 02:32:55 +0100 (BST)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Huacai Chen <chenhuacai@...nel.org>
cc: Marco Crivellari <marco.crivellari@...e.com>, linux-mips@...r.kernel.org, 
    linux-kernel@...r.kernel.org, 
    Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    Frederic Weisbecker <frederic@...nel.org>, 
    Anna-Maria Behnsen <anna-maria@...utronix.de>, 
    Thomas Gleixner <tglx@...utronix.de>, 
    Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v7 1/2] MIPS: Fix idle VS timer enqueue

On Sun, 27 Apr 2025, Huacai Chen wrote:

> > +r4k_wait_exit:
> > +       .set    mips0
> > +       local_irq_disable
> >         jr      ra
> > -        nop
> > -       .set    pop
> > -       END(__r4k_wait)
> > +       END(r4k_wait)
> > +       .previous
> I'm very sorry for the late response, but I think ".previous" should
> be moved to the second patch.

 Indeed; does it even assemble?  Correctness aside I'd rather it didn't 
cause someone a problem with bisecting sometime.  NB I had no opportunity 
either to look at this version earlier.

  Maciej