linux-kernel - Re: [PATCH v7 2/2] MIPS: Move r4k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4dQ8hRfBm2JWmgMzYH5tuy4ph6hyOSXQBLOvtCQ+K9dQ@mail.gmail.com>
Date: Mon, 28 Apr 2025 10:26:51 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Frederic Weisbecker <frederic@...nel.org>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Thomas Gleixner <tglx@...utronix.de>, 
	Peter Zijlstra <peterz@...radead.org>, "Maciej W . Rozycki" <macro@...am.me.uk>
Subject: Re: [PATCH v7 2/2] MIPS: Move r4k_wait() to .cpuidle.text section

Hi, Marco,

On Fri, Apr 4, 2025 at 12:12 AM Marco Crivellari
<marco.crivellari@...e.com> wrote:
>
> Fix missing .cpuidle.text section assignment for r4k_wait() to correct
> backtracing with nmi_backtrace().
>
> Fixes: 97c8580e85cf ("MIPS: Annotate cpu_wait implementations with __cpuidle")
> Signed-off-by: Marco Crivellari <marco.crivellari@...e.com>
> Signed-off-by: Maciej W. Rozycki <macro@...am.me.uk>
> Acked-by: Frederic Weisbecker <frederic@...nel.org>
> ---
>  arch/mips/kernel/genex.S | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 46d975d00298..2cf312d9a3b0 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -104,6 +104,7 @@ handle_vcei:
>
>         __FINIT
>
> +       .section .cpuidle.text,"ax"
If you submit a new version, adding a space before "ax" will be a little better.

Huacai

>         /* Align to 32 bytes for the maximum idle interrupt region size. */
>         .align  5
>  LEAF(r4k_wait)
> --
> 2.49.0
>