linux-kernel - Re: [PATCH] staging: comedi: das16 : fixed a struct warning in code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0feff64-af96-41f8-9c52-3dafeafd7871@mev.co.uk>
Date: Mon, 28 Apr 2025 11:44:16 +0100
From: Ian Abbott <abbotti@....co.uk>
To: Darshan Rathod <darshanrathod475@...il.com>
Cc: hsweeten@...ionengravers.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: das16 : fixed a struct warning in code

On 26/04/2025 10:41, Darshan Rathod wrote:
> fixed a warning messages for a struct
> Signed-off-by: Darshan Rathod <darshanrathod475@...il.com>

There should be a blank line before that "Signed-off-by" line.

The patch subject should not have the "staging:" tag since the code has 
been moved out of the "drivers/staging" directory.

> ---
>   drivers/comedi/drivers/das16.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/das16.c b/drivers/comedi/drivers/das16.c
> index f5ca6c0d4d0c..73717f75d60f 100644
> --- a/drivers/comedi/drivers/das16.c
> +++ b/drivers/comedi/drivers/das16.c
> @@ -956,8 +956,8 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
>   
>   	/* get any user-defined input range */
>   	if (pg_type == das16_pg_none && (min || max)) {
> -		struct comedi_lrange *lrange;
> -		struct comedi_krange *krange;
> +		const struct comedi_lrange *lrange;
> +		const struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */
>   		lrange = comedi_alloc_spriv(s,
> @@ -990,8 +990,8 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
>   
>   	/* get any user-defined output range */
>   	if (min || max) {
> -		struct comedi_lrange *lrange;
> -		struct comedi_krange *krange;
> +		const struct comedi_lrange *lrange;
> +		const struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */
>   		lrange = comedi_alloc_spriv(s,

I do not see how these changes will fix any warning messages.  In fact, 
they will produce compiler errors from the code further down the functions.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-