linux-kernel - Re: [PATCH] i2c: omap: fix deprecated of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hn3gsrizar6xbr4seclnb6xot4fo4ztryks4w7exvztsdzj4f6@jhobhujf3ezi>
Date: Tue, 29 Apr 2025 15:10:13 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Johan Hovold <johan+linaro@...nel.org>, Vignesh R <vigneshr@...com>, 
	Aaro Koskinen <aaro.koskinen@....fi>, Andreas Kemnade <andreas@...nade.info>, 
	Kevin Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, 
	Tony Lindgren <tony@...mide.com>, Janusz Krzysztofik <jmkrzyszt@...il.com>, 
	linux-omap@...r.kernel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use

Hi Johan,

On Fri, Apr 18, 2025 at 11:57:57AM +0200, Johan Hovold wrote:
> On Thu, Apr 17, 2025 at 11:41:51PM +0200, Andi Shyti wrote:
> > On Tue, Apr 15, 2025 at 09:52:30AM +0200, Johan Hovold wrote:
> > > Using of_property_read_bool() for non-boolean properties is deprecated
> > > and results in a warning during runtime since commit c141ecc3cecd ("of:
> > > Warn when of_property_read_bool() is used on non-boolean properties").
> > > 
> > > Fixes: b6ef830c60b6 ("i2c: omap: Add support for setting mux")
> > > Cc: Jayesh Choudhary <j-choudhary@...com>
> > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > 
> > Thanks for your patch! I'm going to drop the Fixes tag, as this
> > isn't really a bug fix but rather a warning suppression during
> > boot time.
> 
> Thanks, but I think you should have kept the Fixes tag and merged this
> for 6.15 (i2c-host-fixes) since this is a new warning in 6.15-rc1 (and
> that does warrant a Fixes tag). Perhaps I should have highlighted that
> better.
> 
> If the offending patch had been posted or merged before such uses
> started generating warnings in 6.14-rc1 then that would have been a
> different matter.

I'm sorry, but as I understand it, the Fixes tag should be used
only when an actual bug is being fixed. I've seen stable
maintainers getting annoyed when it's used for non-bug issues.

The system works perfectly fine even with the warning printed.
It might confuse CI systems, but that shouldn't really be our
concern.

In any case, I see your point and I'm open to hearing a third
opinion.

Thanks,
Andi