linux-kernel - Re: [PATCH] i2c: omap: fix deprecated of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250502145420.6bca53f9@akair>
Date: Fri, 2 May 2025 14:54:20 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Johan Hovold <johan@...nel.org>, Johan Hovold <johan+linaro@...nel.org>,
 Vignesh R <vigneshr@...com>, Aaro Koskinen <aaro.koskinen@....fi>, Kevin
 Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Tony
 Lindgren <tony@...mide.com>, Janusz Krzysztofik <jmkrzyszt@...il.com>,
 linux-omap@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [PATCH] i2c: omap: fix deprecated of_property_read_bool() use

Am Tue, 29 Apr 2025 15:10:13 +0200
schrieb Andi Shyti <andi.shyti@...nel.org>:

> Hi Johan,
> 
> On Fri, Apr 18, 2025 at 11:57:57AM +0200, Johan Hovold wrote:
> > On Thu, Apr 17, 2025 at 11:41:51PM +0200, Andi Shyti wrote:  
> > > On Tue, Apr 15, 2025 at 09:52:30AM +0200, Johan Hovold wrote:  
> > > > Using of_property_read_bool() for non-boolean properties is deprecated
> > > > and results in a warning during runtime since commit c141ecc3cecd ("of:
> > > > Warn when of_property_read_bool() is used on non-boolean properties").
> > > > 
> > > > Fixes: b6ef830c60b6 ("i2c: omap: Add support for setting mux")
> > > > Cc: Jayesh Choudhary <j-choudhary@...com>
> > > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>  
> > > 
> > > Thanks for your patch! I'm going to drop the Fixes tag, as this
> > > isn't really a bug fix but rather a warning suppression during
> > > boot time.  
> > 
> > Thanks, but I think you should have kept the Fixes tag and merged this
> > for 6.15 (i2c-host-fixes) since this is a new warning in 6.15-rc1 (and
> > that does warrant a Fixes tag). Perhaps I should have highlighted that
> > better.
> > 
> > If the offending patch had been posted or merged before such uses
> > started generating warnings in 6.14-rc1 then that would have been a
> > different matter.  
> 
> I'm sorry, but as I understand it, the Fixes tag should be used
> only when an actual bug is being fixed. I've seen stable
> maintainers getting annoyed when it's used for non-bug issues.
> 
hmm, some issue new in -rc1 could be fixed in a later -rcX. I have seen
a lot of typos and other minor stuff getting fixed that way. So
it does not need to be backported to any stable/longterm tree at all.
Are the rules for that really that tough as for stable trees? I really
doubt.

Regards,
Andreas