linux-kernel - Re: [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250429-dragon-of-imaginary-blizzard-e54cbb@kuoka>
Date: Tue, 29 Apr 2025 09:30:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, 
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Greg KH <gregkh@...uxfoundation.org>, 
	Shen Lichuan <shenlichuan@...o.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Peter Zijlstra <peterz@...radead.org>, 
	Charles Hsu <ythsu0511@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver

On Tue, Apr 29, 2025 at 12:13:35AM GMT, Pawel Dembicki wrote:
> Add device tree bindings for Monolithic Power Systems MPQ8785, MPM82504
> and MPM3695 PMBus-compliant voltage regulators.
> 
> These bindings also documents the optional "voltage-scale-loop" property.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> ---
>  .../bindings/hwmon/pmbus/mps,mpq8785.yaml     | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> new file mode 100644
> index 000000000000..e2a3958a61fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +

Drop blank line.

> +$id: http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-device.yaml#

>From where did you take such code? Drop.

> +
> +title: Monolithic Power Systems Multiphase Voltage Regulators with PMBus
> +
> +maintainers:
> +  - Charles Hsu <ythsu0511@...il.com>
> +
> +description: |

Drop |

> +  Monolithic Power Systems digital multiphase voltage regulators with PMBus.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mps,mpq8785
> +      - mps,mpm82504
> +      - mps,mpm3695-10

Keep alphabetical order

> +
> +  reg:
> +    maxItems: 1
> +
> +  voltage-scale-loop:

Missing vendor prefix, missing tests, missing property unit suffix
(percent? bpp?)

Or this should be just output voltage in microvolts.

Best regards,
Krzysztof