linux-kernel - Re: [PATCH net v2 2/2] net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBCAE46MW4PvBb2_@pengutronix.de>
Date: Tue, 29 Apr 2025 09:30:27 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	"Russell King (Oracle)" <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
	stable@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] net: phy: micrel: remove KSZ9477 EEE quirks
 now handled by phylink

On Tue, Apr 29, 2025 at 09:23:17AM +0200, Oleksij Rempel wrote:
> The KSZ9477 PHY driver contained workarounds for broken EEE capability
> advertisements by manually masking supported EEE modes and forcibly
> disabling EEE if MICREL_NO_EEE was set.
> 
> With proper MAC-side EEE handling implemented via phylink, these quirks
> are no longer necessary. Remove MICREL_NO_EEE handling and the use of
> ksz9477_get_features().
> 
> This simplifies the PHY driver and avoids duplicated EEE management logic.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Not all was included in the kernel build bot answer:
kernel test robot notices the stable kernel rule is not satisfied.

I'll resend with cc: stable@... included.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |