linux-kernel - Re: [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2044b305-8786-49b9-82e2-aa294434c24e@kernel.org>
Date: Tue, 29 Apr 2025 09:33:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "kyrie.wu@...iatek.corp-partner.google.com"
 <kyrie.wu@...iatek.corp-partner.google.com>,
 "mchehab@...nel.org" <mchehab@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek,
 mt8196-jpgdec compatible

On 28/04/2025 10:19, Kyrie Wu (吴晗) wrote:
> On Mon, 2025-04-28 at 09:04 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Fri, Apr 25, 2025 at 04:53:17PM GMT, Kyrie Wu wrote:
>>> Compared to the previous generation IC, the MT8196 uses SMMU
>>> instead of IOMMU and supports features such as dynamic voltage
>>> and frequency scaling. Therefore, add "mediatek,mt8196-jpgdec"
>>> compatible to the binding document.
>>>
>>> Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
>>
>> I gave you a link to the exact part of documentation about prefixes
>> to
>> read. I do not see improvements, so I do not believe you read it. I
>> could
>> imagine people skip reading entire doc (who would listen to the
>> reviewer, right?), but if I give direct link to specific chapter and
>> still not following it, makes me feel quite dissapointed.
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
> 
> I would like to apologize to you again here. I am very sorry for
> wasting your precious time. I changed the subject from "dt-bindings:
> mediatek: XXX" to "dt-bindings: media: mediatek,jpeg: XXX" in V3. This
> change is based on your previous suggestion. Use this command, git log
> --oneline --
> Documentation/devicetree/bindings/media/, obtained. But this
> modification does not meet your requirements. Should I change the
> subject to "media: dt-bindings: mediatek,jpeg: XXX"?
> 
> Another question I need to ask you:
> MT8195 and MT8196 both have multi-core hardware architectures. Do we
> need to change the yaml file name from 'mediatek,mt8195-jpegenc.yaml'
> to 'mediatek,multi-core-jpegenc.yaml'? In my opinion, this is more
> appropriate. What is your suggestion?
I asked above about link to documentation. You ignored that part, so
let's be specific:

Did you or did you not read the doc I linked last time?

Best regards,
Krzysztof