linux-kernel - Re: [PATCH v3 00/12] Enable jpeg enc & dec multi-hardwares for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4557dde5-c0fe-4339-8c4c-291b186ee86f@kernel.org>
Date: Tue, 29 Apr 2025 09:34:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "kyrie.wu@...iatek.corp-partner.google.com"
 <kyrie.wu@...iatek.corp-partner.google.com>,
 "mchehab@...nel.org" <mchehab@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 00/12] Enable jpeg enc & dec multi-hardwares for MT8196

On 28/04/2025 10:10, Kyrie Wu (吴晗) wrote:
> On Mon, 2025-04-28 at 09:01 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Fri, Apr 25, 2025 at 04:53:16PM GMT, Kyrie Wu wrote:
>>> This series adds support for mt8196 multi-hardwares jpeg enc & dec,
>>> by first adding mt8196 jpegdec and jpegenc compatible to install
>>> kernel driver. Add smmu setting to support smmu and iommu at the
>>> same time.
>>> Secondly refactor buffer and clock setting to support multi-hw jpeg
>>> working.
>>> Lastly, fix some bugs, including resolution change handleing, stop
>>> streaming sw flow and others.
>>>
>>> This series has been tested with MT8196 tast test.
>>> Encoding and decoding worked for this chip.
>>>
>>> Patches 1-3 Adds jpeg encoder and decoder compatible.
>>> Patches 4 add jpeg smmu sid setting.
>>> Patches 5 fix jpeg hw count setting to support different chips.
>>> Patches 6 refactor jpeg buffer payload setting to handle buffer
>>> size bug while resolution changed.
>>> Patches 7 reconstruct jpeg dst buffer layout.
>>> Patches 8 fix multi-core stop streaming flow
>>> Patches 9 refactor multi-core clk suspend/resume setting
>>> Patches 10 fix decoding buffer number setting timing issue
>>> Patches 11 refactor decoding resolution change operation
>>> Patches 12 fix remove buffer operation
>>>
>>> ---
>>> This series patches dependent on:
>>> [1]
>>>
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20250424090824.5309-1-jianhua.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!hDjzydf2blyIhdAkYs_NbqpEaaWTuolLbaHLDw8hLg4BJ87r7ePzKkET-uDw24U6YXAqmbSxItem1Q$
>>>
>>> Changes compared with v2:
>>> --refactor smmu sid setting function interface
>>> --Some modifications for patch v2's review comments.
>>
>> This is very vague. What exactly changed.
> 
> Dear Krzysztof,
> 
> Sorry for the shortly descriptions. The main changing in V3 is fixed
> dt-bindings comments by you.


What changed? What comments? Again way too vague.


Best regards,
Krzysztof