linux-kernel - Re: [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41e258daf6ffaf14c3330c95860d70c95f9b61a2.camel@mediatek.com>
Date: Tue, 29 Apr 2025 08:25:20 +0000
From: Kyrie Wu (吴晗) <Kyrie.Wu@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"kyrie.wu@...iatek.corp-partner.google.com"
	<kyrie.wu@...iatek.corp-partner.google.com>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "hverkuil-cisco@...all.nl"
	<hverkuil-cisco@...all.nl>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek,
 mt8196-jpgdec compatible

On Tue, 2025-04-29 at 09:33 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 28/04/2025 10:19, Kyrie Wu (吴晗) wrote:
> > On Mon, 2025-04-28 at 09:04 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Fri, Apr 25, 2025 at 04:53:17PM GMT, Kyrie Wu wrote:
> > > > Compared to the previous generation IC, the MT8196 uses SMMU
> > > > instead of IOMMU and supports features such as dynamic voltage
> > > > and frequency scaling. Therefore, add "mediatek,mt8196-jpgdec"
> > > > compatible to the binding document.
> > > > 
> > > > Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
> > > 
> > > I gave you a link to the exact part of documentation about
> > > prefixes
> > > to
> > > read. I do not see improvements, so I do not believe you read it.
> > > I
> > > could
> > > imagine people skip reading entire doc (who would listen to the
> > > reviewer, right?), but if I give direct link to specific chapter
> > > and
> > > still not following it, makes me feel quite dissapointed.
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Dear Krzysztof,
> > 
> > I would like to apologize to you again here. I am very sorry for
> > wasting your precious time. I changed the subject from "dt-
> > bindings:
> > mediatek: XXX" to "dt-bindings: media: mediatek,jpeg: XXX" in V3.
> > This
> > change is based on your previous suggestion. Use this command, git
> > log
> > --oneline --
> > Documentation/devicetree/bindings/media/, obtained. But this
> > modification does not meet your requirements. Should I change the
> > subject to "media: dt-bindings: mediatek,jpeg: XXX"?
> > 
> > Another question I need to ask you:
> > MT8195 and MT8196 both have multi-core hardware architectures. Do
> > we
> > need to change the yaml file name from 'mediatek,mt8195-
> > jpegenc.yaml'
> > to 'mediatek,multi-core-jpegenc.yaml'? In my opinion, this is more
> > appropriate. What is your suggestion?
> 
> I asked above about link to documentation. You ignored that part, so
> let's be specific:
> 
> Did you or did you not read the doc I linked last time?
> 
> Best regards,
> Krzysztof

Dear Krzysztof,

I have read the following link you provided:

https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html*i-for-patch-submitters__;Iw!!CTRNKA9wMg0ARbw!lYnGLcOBQIh9yQUyMcteKxvcKQv2_eSc4udxkDDWXikTyN8VcXyYDgGuK-8UZWxKE5Pmg3D5lvplcw$

How to add the prefix of the patch's subject, the link and command line
you provided respectively introduce two different methods:
'media:dt-bindings:xxx' is the method provided in the link you
provided;
‘dt-bindings:media:xxx’ is the information obtained from the command
you provided;
I have previously sent you an email asking how you would choose between
the two (
https://patchwork.kernel.org/project/linux-mediatek/patch/20250410063006.5313-3-kyrie.wu@mediatek.com/
). But you didn't reply. Therefore, I used the previously merged patch
approach in V3:
b15a5ce86383 dt-bindings: media: mediatek,jpeg: Relax IOMMU max item
count
My behavior has caused you inconvenience and I have misunderstood your
instructions. I once again sincerely apologize to you. I hope you can
understand and accept it.
Finally, please give some correct guidance.

Thanks!

Regards,
Kyrie.