linux-kernel - Re: [PATCH v3] ASoC: SOF: topology: Fix null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fcc3871-4367-4ff5-9529-d1bada6f06e1@collabora.com>
Date: Tue, 29 Apr 2025 11:23:27 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Julien Massot <julien.massot@...labora.com>, kernel@...labora.com,
 Liam Girdwood <lgirdwood@...il.com>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: Liam Girdwood <liam.r.girdwood@...el.com>,
 sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, Laurentiu Mihalcea <laurentiu.mihalcea@....com>
Subject: Re: [PATCH v3] ASoC: SOF: topology: Fix null pointer dereference

On 4/29/25 10:07 AM, Julien Massot wrote:
> The "get_function_tplg_files" function is only applicable to
> ACPI-based devices (sof_pdata->machine and sof_pdata->not of_machine).

s/not //

> Skip this check for OF-based devices to avoid a NULL pointer
> dereference in snd_sof_load_topology().
> 
> Fixes: 6d5997c412cc ("ASoC: SOF: topology: load multiple topologies")
> Reviewed-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> Signed-off-by: Julien Massot <julien.massot@...labora.com>
> ---
> Changes in v3:
> - More detailled commit message
> - Link to v2: https://lore.kernel.org/r/20250428-fixup-of-sof-topology-v2-1-7966515a81b7@collabora.com
> 
> Changes in v2:
> - Better commit message as suggested
> - Link to v1: https://lore.kernel.org/r/20250428-fixup-of-sof-topology-v1-1-dc14376da258@collabora.com
> ---
>  sound/soc/sof/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

With the above fixed:

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>