linux-kernel - Re: [PATCH] x86/microcode/amd: fix the return value when microcode has no update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429092251.GEaBCaa2Y1tVOnl77A@fat_crate.local>
Date: Tue, 29 Apr 2025 11:22:51 +0200
From: Borislav Petkov <bp@...en8.de>
To: Annie Li <jiayanli@...gle.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Nikolay Borisov <nik.borisov@...e.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/microcode/amd: fix the return value when microcode
 has no update

On Tue, Apr 29, 2025 at 08:43:16AM +0000, Annie Li wrote:
> In commit 6f059e634dcd("x86/microcode: Clarify the late load logic"), the
> return value is UCODE_OK if the load is up-to-date in amd platform, which
> leads to load_late_locked() returning -EBADFD.
> 
> This is different from the intel platform, which will return UCODE_NFOUND
> and is more reasonable.
> 
> Fix the return to UCODE_NFOUND to avoid -EBADFD error.

... and return -ENOENT instead?

Is that better?

Or would it be even better for the switch-case to handle UCODE_OK too?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette