linux-kernel - Re: [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address writes in 8D-8D-8D mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <10b40148-b949-442d-9d43-0db09517269a@linaro.org>
Date: Tue, 29 Apr 2025 10:22:40 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Luke Wang <ziniu.wang_1@....com>,
 "pratyush@...nel.org" <pratyush@...nel.org>
Cc: "broonie@...nel.org" <broonie@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
 "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
 "michael@...le.cc" <michael@...le.cc>,
 "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
 "p.yadav@...com" <p.yadav@...com>, "richard@....at" <richard@....at>,
 "vigneshr@...com" <vigneshr@...com>, Bough Chen <haibo.chen@....com>,
 Han Xu <han.xu@....com>
Subject: Re: [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address
 writes in 8D-8D-8D mode



On 4/29/25 10:03 AM, Luke Wang wrote:
> Hi Pratyush,
> 
>  
> 
> I'm following up on this patch series [1] Avoid odd length/address read/
> writes in 8D-8D-8D mode. While some of the series has been merged, the
> patch 4-6 remains unmerged.
> 
>  
> 
> In fact, we also encountered similar read/write issue of odd address/
> length with NXP FSPI controller (spi-nxp-fspi.c). Currently, we handled
> the odd address/length in the controller driver, but I think this should
> be a common issue in the octal dtr mode. Was there a technical reason
> for not merging the core layer solution?

I guess I stumbled on those small comments and did not consider the
greater benefit of taking the patches. No one cared and we forgot about
it. Please address the comments and resubmit.
> 
>  
> 
> [1] Original submission:  https://lore.kernel.org/
> all/20210531181757.19458-1-p.yadav@...com/ <https://lore.kernel.org/
> all/20210531181757.19458-1-p.yadav@...com/>
> 
>  
> 
> Regards,
> 
> Luke Wang
> 
>  
>