linux-kernel - Re: [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address writes in 8D-8D-8D mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs0zffo3gea.fsf@kernel.org>
Date: Wed, 07 May 2025 09:43:25 +0000
From: Pratyush Yadav <pratyush@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Luke Wang <ziniu.wang_1@....com>,  "pratyush@...nel.org"
 <pratyush@...nel.org>,  "broonie@...nel.org" <broonie@...nel.org>,
  "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
  "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
  "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
  "michael@...le.cc" <michael@...le.cc>,  "miquel.raynal@...tlin.com"
 <miquel.raynal@...tlin.com>,  "p.yadav@...com" <p.yadav@...com>,
  "richard@....at" <richard@....at>,  "vigneshr@...com" <vigneshr@...com>,
  Bough Chen <haibo.chen@....com>,  Han Xu <han.xu@....com>
Subject: Re: [PATCH v2 6/6] mtd: spi-nor: core: avoid odd length/address
 writes in 8D-8D-8D mode

Hi Luke,

On Tue, Apr 29 2025, Tudor Ambarus wrote:

> On 4/29/25 10:03 AM, Luke Wang wrote:
>> Hi Pratyush,
>> 
>> I'm following up on this patch series [1] Avoid odd length/address read/
>> writes in 8D-8D-8D mode. While some of the series has been merged, the
>> patch 4-6 remains unmerged.
>> 
>> In fact, we also encountered similar read/write issue of odd address/
>> length with NXP FSPI controller (spi-nxp-fspi.c). Currently, we handled
>> the odd address/length in the controller driver, but I think this should
>> be a common issue in the octal dtr mode. Was there a technical reason
>> for not merging the core layer solution?
>
> I guess I stumbled on those small comments and did not consider the
> greater benefit of taking the patches. No one cared and we forgot about
> it. Please address the comments and resubmit.

Yes, it should have been a simple next revision from me but apparently
it fell through the cracks. I do strongly agree that this should be done
in SPI NOR, and not in controller drivers. So it would be great if you
can respin the remaining patches of the series.

-- 
Regards,
Pratyush Yadav