| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e97d3388a5b4272d70d7379b020843a47874a104.camel@pengutronix.de> Date: Tue, 29 Apr 2025 11:39:20 +0200 From: Lucas Stach <l.stach@...gutronix.de> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com> Cc: devicetree@...r.kernel.org, Francesco Dolcini <francesco@...cini.it>, imx@...ts.linux.dev, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux@...tq-group.com Subject: Re: [PATCH 0/6] arm64: dts: imx: Move Ethernet aliases out of SoC DTSI Hi Krzysztof, Am Freitag, dem 25.04.2025 um 21:48 +0200 schrieb Krzysztof Kozlowski: > Not tested on hardware. > > Ethernet interface, like other exposed interfaces, aliases depend on > actual board configuration, e.g. its labeling, thus aliases should be > defined per each board or each SoM. > > Some boards (e.g. Gateworks) follow this convention but many do not. > > This is continuation of my comments from: > https://lore.kernel.org/r/16a98816-f43c-4f4d-940e-9da30cb1f73f@kernel.org > The i.MX boards have traditionally listed aliases for many hardware peripherals with the same numbering that's used in the SoC reference manual. Boards always have the option to override those aliases if they have a good reason to do so, e.g. labeling on the physical device. Other users besides Linux rely on fixed numbering provided by the aliases. Both barebox and U-Boot number their ethernet interfaces according to the alias. While you seem to add back aliases for in-tree boards, this breaks the majority of boards that include the kernel DTSI from an out-of-tree board. I can understand that we can't always accommodate these users, but I simply don't see the strong benefit of this patch to justify creating churn and possible regressions with those OOT users. Having those aliases in the DTSI has been common practice on the i.MX platform since 2012, long before there was any strong consensus on how those aliases should be used. Breaking existing users for the sake of aligning the i.MX platform with more idiomatic DT usage does not seem to be a worthwhile trade-off to me. Regards, Lucas > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (6): > arm64: dts: imx8qxp: Move Ethernet aliases out of SoC DTSI > arm64: dts: imx8dxl: Move Ethernet aliases out of SoC DTSI > arm64: dts: imx8mm: Move Ethernet aliases out of SoC DTSI > arm64: dts: imx8mn: Move Ethernet aliases out of SoC DTSI > arm64: dts: imx8mq: Move Ethernet aliases out of SoC DTSI > arm64: dts: imx8qm: Add Ethernet aliases > > arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 2 ++ > arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 1 + > arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 2 -- > arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-innocomm-wb15-evk.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-phg.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mm-ucm-som.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-verdin-ivy.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm-verdin-yavia.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 - > arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2-common.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 - > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 + > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-sr-som.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 - > arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 5 +++++ > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 1 + > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 ++++ > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 -- > arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi | 6 ++++++ > arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi | 1 + > arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi | 1 + > arch/arm64/boot/dts/freescale/mba8mx.dtsi | 4 ++++ > arch/arm64/boot/dts/freescale/mba8xx.dtsi | 2 ++ > 56 files changed, 143 insertions(+), 7 deletions(-) > --- > base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc > change-id: 20250425-dts-imx-aliases-ethernet-37d8552939de > > Best regards,
Powered by blists - more mailing lists