linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB95QAT4JJFYiXviJB78KELFnsitDj=Zb3EM_1F8uqiRHMwBhw@mail.gmail.com>
Date: Tue, 29 Apr 2025 13:30:09 +0200
From: Eugene Shalygin <eugene.shalygin@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Alexei Safin <a.safin@...a.ru>, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN_ONCE() on invalid
 sensor index

> If this is seen, it is an implementation error which needs to be fixed.
> Returning an error to userspace will leave users annoyed but will not
> result in a fix. The warning backtrace is warranted in this situation.

Thanks for the explanation! I'm still not convinced that such a
generic error message (without the type and channel) can be of great
help. Something serious needs to happen to trigger this error, like a
hardware change, or a RAM failure... If the purpose of the message is
only to grab attention, it could say that explicitly. But anyway,

Reviewed-by: Eugene Shalygin <eugene.shalygin@...il.com>

Eugene