linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38c7114e-3ea0-4f4b-bb12-5715c992656a@roeck-us.net>
Date: Tue, 29 Apr 2025 21:12:59 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Eugene Shalygin <eugene.shalygin@...il.com>
Cc: Alexei Safin <a.safin@...a.ru>, Jean Delvare <jdelvare@...e.com>,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN_ONCE() on invalid
 sensor index

On 4/29/25 04:30, Eugene Shalygin wrote:
>> If this is seen, it is an implementation error which needs to be fixed.
>> Returning an error to userspace will leave users annoyed but will not
>> result in a fix. The warning backtrace is warranted in this situation.
> 
> Thanks for the explanation! I'm still not convinced that such a
> generic error message (without the type and channel) can be of great

Feel free to suggest a better one. Maybe I misunderstood your earlier
concerns, but it seemed to me that you objected to having a message
in the first place, not to its contents.

Thanks,
Guenter

> help. Something serious needs to happen to trigger this error, like a
> hardware change, or a RAM failure... If the purpose of the message is
> only to grab attention, it could say that explicitly. But anyway,
> 
> Reviewed-by: Eugene Shalygin <eugene.shalygin@...il.com>
> 
> Eugene