linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB95QASErsOGibQ1+kB2LjNr-v3-KS86w8KvGLurB67D_4Bt4Q@mail.gmail.com>
Date: Thu, 1 May 2025 10:07:03 +0200
From: Eugene Shalygin <eugene.shalygin@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Alexei Safin <a.safin@...a.ru>, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN_ONCE() on invalid
 sensor index

On Wed, 30 Apr 2025 at 06:13, Guenter Roeck <linux@...ck-us.net> wrote:

> > Thanks for the explanation! I'm still not convinced that such a
> > generic error message (without the type and channel) can be of great
>
> Feel free to suggest a better one. Maybe I misunderstood your earlier
> concerns, but it seemed to me that you objected to having a message
> in the first place, not to its contents.

The only two conditions I can imaging to trigger the log message are
hardware and/or firmware change and RAM instability. In both cases the
message is not helpful: for the hardware change case I would need
sensor type and channel, for the RAM-related cases I would need to
know how often the problem repeats itself. Neither is possible with
this log message, and therefore I'd rather log every time and with
sensor type and channel.

Best regards,
Eugene