[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025043006-snowflake-headless-e417@gregkh>
Date: Wed, 30 Apr 2025 09:55:24 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Matthew Maurer <mmaurer@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Sami Tolvanen <samitolvanen@...gle.com>,
linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 2/8] rust: debugfs: Bind file creation for long-lived
Display
On Tue, Apr 29, 2025 at 11:15:56PM +0000, Matthew Maurer wrote:
> + /// Create a file in a DebugFS directory with the provided name, and contents from invoking
> + /// [`Display::fmt`] on the provided reference.
> + ///
> + /// # Example
> + ///
> + /// ```
> + /// # use kernel::c_str;
> + /// # use kernel::debugfs::Dir;
> + /// let dir = Dir::new(c_str!("my_debugfs_dir"), None)?;
Again, can never fail, so don't check it.
> + /// let file = dir.display_file(c_str!("foo"), &200)?;
Again, can never fail, so don't check it.
And "200" is wrong, did you test these?
> + /// # Ok::<(), Error>(())
> + /// ```
> + pub fn display_file<T: Display + Sized>(
> + &self,
> + name: &CStr,
> + data: &'static T,
> + ) -> Result<ARef<Self>> {
Again, will always succeed, you don't want any checking of Result<>
thanks,
greg k-h
Powered by blists - more mailing lists