linux-kernel - Re: [PATCH v1 1/2] ASoC: intel/sdw_utils: Add volume limit to cs42l43 speakers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBISHAyAHPMB/wkW@opensource.cirrus.com>
Date: Wed, 30 Apr 2025 13:05:48 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Stefan Binding <sbinding@...nsource.cirrus.com>
Cc: Mark Brown <broonie@...nel.org>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v1 1/2] ASoC: intel/sdw_utils: Add volume limit to
 cs42l43 speakers

On Wed, Apr 30, 2025 at 11:31:19AM +0100, Stefan Binding wrote:
> The volume control for cs42l43 speakers has a maximum gain of +31.5 dB.
> However, for many use cases, this can cause distorted audio, depending
> various factors, such as other signal-processing elements in the chain,
> for example if the audio passes through a gain control before reaching
> the codec or the signal path has been tuned for a particular maximum
> gain in the codec.
> 
> In the case of systems which use the soc_sdw_cs42l43 driver, audio will
> likely be distorted in all cases above 0 dB, therefore add a volume
> limit of 128, which is 0 dB maximum volume inside this driver.
> 
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles