linux-kernel - Re: [PATCH 3/5] powerpc: 44x/gpio: use new line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fab558c6-0403-45f4-97c3-9c71db678a20@csgroup.eu>
Date: Wed, 30 Apr 2025 19:35:26 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Anatolij Gustschin <agust@...x.de>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 3/5] powerpc: 44x/gpio: use new line value setter
 callbacks



Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit :
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   arch/powerpc/platforms/44x/gpio.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
> index e5f2319e5cbe..d540e261d85a 100644
> --- a/arch/powerpc/platforms/44x/gpio.c
> +++ b/arch/powerpc/platforms/44x/gpio.c
> @@ -75,8 +75,7 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
>   		clrbits32(&regs->or, GPIO_MASK(gpio));
>   }
>   
> -static void
> -ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
> +static int ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
>   {
>   	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);
>   	unsigned long flags;
> @@ -88,6 +87,8 @@ ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
>   	spin_unlock_irqrestore(&chip->lock, flags);
>   
>   	pr_debug("%s: gpio: %d val: %d\n", __func__, gpio, val);
> +
> +	return 0;
>   }
>   
>   static int ppc4xx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio)
> @@ -179,7 +180,7 @@ static int __init ppc4xx_add_gpiochips(void)
>   		gc->direction_input = ppc4xx_gpio_dir_in;
>   		gc->direction_output = ppc4xx_gpio_dir_out;
>   		gc->get = ppc4xx_gpio_get;
> -		gc->set = ppc4xx_gpio_set;
> +		gc->set_rv = ppc4xx_gpio_set;
>   
>   		ret = of_mm_gpiochip_add_data(np, mm_gc, ppc4xx_gc);
>   		if (ret)
>