linux-kernel - Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove redundant code in lvts_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <77c4437f2643475de495733d7840421198b78f49.camel@mediatek.com>
Date: Wed, 30 Apr 2025 08:25:57 +0000
From: Chang-Yi Lin (林長億)
	<ds_chang-yi.lin@...iatek.com>
To: "treapking@...omium.org" <treapking@...omium.org>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>, "nico@...xnic.net"
	<nico@...xnic.net>, "rafael@...nel.org" <rafael@...nel.org>,
	"AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>,
	"rui.zhang@...el.com" <rui.zhang@...el.com>, "lukasz.luba@....com"
	<lukasz.luba@....com>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC: "duminjie@...o.com" <duminjie@...o.com>, Alexandre Mergnat
	<amergnat@...libre.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "bchihi@...libre.com"
	<bchihi@...libre.com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Nicolas Prado <nfraprado@...labora.com>
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove redundant
 code in lvts_ctrl_configure

On Wed, 2024-04-10 at 11:55 +0200, AngeloGioacchino Del Regno wrote:
> Il 10/04/24 02:07, Pin-yen Lin ha scritto:
> > The removed variable assignment is never written to the register,
> > so it
> > has no effect on the device behavior.  Mediatek has confirmed that
> > it
> > is not required to initialize this register for current platforms,
> > so
> > remove this segment to avoid confusion.
> > 
> > Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> > 
> 
> Added Nicolas Pitre to the loop;
> 
> Nicolas, since you're pushing support for those, can you please check
> if CALSCALE
> is used/useful/necessary on MT8186/88 before I give a R-b to this
> commit?
> 
> P.S.: Can anyone from MediaTek please confirm if the 0x300 value is
> right for this
>        register? I'd still like Linux to properly initialize the
> registers, even if
>        this could technically be a default value.
> 
> 
> > ---
> > 
> >   drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/thermal/mediatek/lvts_thermal.c
> > b/drivers/thermal/mediatek/lvts_thermal.c
> > index fd4bd650c77a..48d2f8ba3f18 100644
> > --- a/drivers/thermal/mediatek/lvts_thermal.c
> > +++ b/drivers/thermal/mediatek/lvts_thermal.c
> > @@ -985,12 +985,6 @@ static int lvts_ctrl_configure(struct device
> > *dev, struct lvts_ctrl *lvts_ctrl)
> >   	value = LVTS_TSSEL_CONF;
> >   	writel(value, LVTS_TSSEL(lvts_ctrl->base));
> >   
> > -	/*
> > -	 * LVTS_CALSCALE : ADC voltage round
> > -	 */
> > -	value = 0x300;
> > -	value = LVTS_CALSCALE_CONF;
> 
> As a side note, I believe that the original author wanted to write,
> instead...
> 
> 	value = LVTS_CALSCALE_CONF;
> 	writel(value, LVTS_CALSCALE(lvts_ctrl->base);
> 
> Cheers,
> Angelo
> 
> > -
> >   	/*
> >   	 * LVTS_MSRCTL0 : Sensor filtering strategy
> >   	 *
> 
> 
Base on xiaojun.zheng
     The register is for PTP function, and in MT8192 it's not required
to do such setting any more