linux-kernel - Re: [PATCH 2/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_serializer_temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lwxi27a537rmzvu7fj3nnsyik5cvrgasxrtwtxkjho7wohuk5e@xoshmwsm2lpn>
Date: Wed, 30 Apr 2025 14:04:48 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] media: i2c: ds90ub960: Fix uninitialized variable in
 ub960_serializer_temp_ramp()

Hi Dan,

On Apr 30, 2025 at 11:27:36 +0300, Dan Carpenter wrote:
> The "ret" variable is not initialized on the success path.
> 
> Fixes: a05744749600 ("media: i2c: ds90ub9xx: Set serializer temperature ramp")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index 8075bffbac2b..cf104461b9a7 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -2058,7 +2058,7 @@ static int ub960_serializer_temp_ramp(struct ub960_rxport *rxport)
>  	u8 temp_dynamic_cfg;
>  	u8 nport = rxport->nport;
>  	u8 ser_temp_code;
> -	int ret;
> +	int ret = 0;

Oops, thanks for the fix.

Reviewed-By: Jai Luthra <jai.luthra@...asonboard.com>

>  
>  	/* Configure temp ramp only on UB953 */
>  	if (!fwnode_device_is_compatible(rxport->ser.fwnode, "ti,ds90ub953-q1"))
> -- 
> 2.47.2
> 

-- 
Thanks,
Jai

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)