linux-kernel - Re: [PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tumx2kbyzqf2q4ibh3v5mmh7hxsalttpsk36sfcv63pomi5wkq@nrls55uvrmxt>
Date: Wed, 30 Apr 2025 14:05:07 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...all.nl>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] media: i2c: ds90ub960: Fix uninitialized variable in
 ub960_rxport_bc_ser_config()

On Apr 30, 2025 at 11:27:42 +0300, Dan Carpenter wrote:
> The "ret" variable is not initialized on success.  Set it to zero.
> 
> Fixes: e2a3b695bc5f ("media: i2c: ds90ub960: Configure serializer using back-channel")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-By: Jai Luthra <jai.luthra@...asonboard.com>

> ---
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index cf104461b9a7..ed2cf9d247d1 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -2133,7 +2133,7 @@ static int ub960_rxport_bc_ser_config(struct ub960_rxport *rxport)
>  	struct ub960_data *priv = rxport->priv;
>  	struct device *dev = &priv->client->dev;
>  	u8 nport = rxport->nport;
> -	int ret;
> +	int ret = 0;
>  
>  	/* Skip port if serializer's address is not known */
>  	if (rxport->ser.addr < 0) {
> -- 
> 2.47.2
> 

-- 
Thanks,
Jai

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)