linux-kernel - Re: linux-next: build failure after merge of the rust-xarray tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250501182958.110abc0b@canb.auug.org.au>
Date: Thu, 1 May 2025 18:29:58 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Andreas Hindborg <a.hindborg@...nel.org>, Tamir Duberstein
 <tamird@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the rust-xarray tree

Hi Viresh,

On Wed, 30 Apr 2025 16:12:34 +0530 Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 30-04-25, 20:23, Stephen Rothwell wrote:
> > Caused by commit
> > 
> >   a68f46e83747 ("rust: types: add `ForeignOwnable::PointedTo`")
> > 
> > interacting with commit
> > 
> >   254df142ab42 ("rust: cpufreq: Add initial abstractions for cpufreq framework")
> > 
> > from the cpufreq-arm tree.
> > 
> > I don't know how to fix this up, so I have dropped the rust-xarray tree
> > for today.  
> 
> Probably this:
> 
> diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs
> index 49246e50f67e..82d20b999e6c 100644
> --- a/rust/kernel/cpufreq.rs
> +++ b/rust/kernel/cpufreq.rs
> @@ -630,7 +630,7 @@ pub fn data<T: ForeignOwnable>(&mut self) -> Option<<T>::Borrowed<'_>> {
>              None
>          } else {
>              // SAFETY: The data is earlier set from [`set_data`].
> -            Some(unsafe { T::borrow(self.as_ref().driver_data) })
> +            Some(unsafe { T::borrow(self.as_ref().driver_data.cast()) })
>          }
>      }
> 
> @@ -657,7 +657,7 @@ fn clear_data<T: ForeignOwnable>(&mut self) -> Option<T> {
>              let data = Some(
>                  // SAFETY: The data is earlier set by us from [`set_data`]. It is safe to take
>                  // back the ownership of the data from the foreign interface.
> -                unsafe { <T as ForeignOwnable>::from_foreign(self.as_ref().driver_data) },
> +                unsafe { <T as ForeignOwnable>::from_foreign(self.as_ref().driver_data.cast()) },
>              );
>              self.as_mut_ref().driver_data = ptr::null_mut();
>              data
> 
> 
> Andreas, is your xarray-next branch immmutable ? I can rebase over the
> change then.

I have applied that as a merge fix up for the rust-xarray tree merge
from today.  (This time running "make rustftmcheck" :-))
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped