linux-kernel - Re: [RFC PATCH v2 2/2] wifi: Add Nordic nRF70 series Wi-Fi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGhaMFNhq-O3O0TCj6cvzvTqzPQKE_id67U0hZjV0V2uKV91Tw@mail.gmail.com>
Date: Thu, 1 May 2025 12:41:05 +0200
From: Artur Rojek <artur@...clusive.pl>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: broonie@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org, 
	jakub@...clusive.pl, johannes@...solutions.net, krzk+dt@...nel.org, 
	lgirdwood@...il.com, linux-kernel@...r.kernel.org, 
	linux-wireless@...r.kernel.org, robh@...nel.org, s.hauer@...gutronix.de, 
	ulf.axelsson@...dicsemi.no, wojciech@...clusive.pl
Subject: Re: [RFC PATCH v2 2/2] wifi: Add Nordic nRF70 series Wi-Fi driver

Hi Christophe,

thanks for the review!
Reply inline.

On Fri, Apr 25, 2025 at 9:31 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 22/04/2025 à 19:59, Artur Rojek a écrit :
> > Introduce support for Nordic Semiconductor nRF70 series wireless
> > companion IC.
> >
>
> Hi,
> ...
>
> > +     /* vpwr is mandatory, but we want to catch the -ENODEV error. */
> > +     priv->vpwr = devm_regulator_get_optional(dev, "vpwr");
> > +     if (IS_ERR(priv->vpwr))
> > +             return dev_err_probe(dev, PTR_ERR(priv->vpwr),
> > +                                  "Unable to find vpwr-supply property");
> > +
> > +     priv->vio = devm_regulator_get_optional(dev, "vio");
> > +     if (IS_ERR(priv->vio) && PTR_ERR(priv->vio) != -ENODEV) {
> > +             return dev_err_probe(dev, PTR_ERR(priv->vio),
> > +                                  "Invalid vio-supply property");
> > +     }
>
> Unneeded extra { }
>
> > +
> > +     irq = of_irq_get_byname(dev->of_node, "host-irq");
> > +     if (irq <= 0)
> > +             return dev_err_probe(dev, irq, "Unable to find host-irq\n");
>
> If irq is 0, is it expected to return sucess here?

No, return value of 0 is considered IRQ mapping failure, as per
of_irq_get_byname() documentation. Perhaps it warrants a different error
message, though.

Cheers,
Artur

>
> > +
> > +     mutex_init(&priv->write_lock);
> > +     mutex_init(&priv->read_lock);
> ...
>
> CJ