[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJ-ks9=XJ_cX8=vCtAr8Qr+4iaX9fyc8+djiBmg8=FxJTggS9w@mail.gmail.com>
Date: Fri, 2 May 2025 09:01:59 -0700
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
linux-kernel@...r.kernel.org, patches@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH 5/5] rust: clean Rust 1.88.0's `clippy::uninlined_format_args`
lint
On Fri, May 2, 2025 at 7:04 AM Miguel Ojeda <ojeda@...nel.org> wrote:
>
> Starting with Rust 1.88.0 (expected 2025-06-26) [1], `rustc` may move
> back the `uninlined_format_args` to `style` from `pedantic` (it was
> there waiting for rust-analyzer suppotr), and thus we will start to see
Typo: s/suppotr/support/
> lints like:
>
> warning: variables can be used directly in the `format!` string
> --> rust/macros/kunit.rs:105:37
> |
> 105 | let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{}", test);
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
> help: change this to
> |
> 105 - let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{}", test);
> 105 + let kunit_wrapper_fn_name = format!("kunit_rust_wrapper_{test}");
>
> There is even a case that is a pure removal:
>
> warning: variables can be used directly in the `format!` string
> --> rust/macros/module.rs:51:13
> |
> 51 | format!("{field}={content}\0", field = field, content = content)
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
> help: change this to
> |
> 51 - format!("{field}={content}\0", field = field, content = content)
> 51 + format!("{field}={content}\0")
>
> The lints all seem like nice cleanups, thus just apply them.
>
> We may want to disable `allow-mixed-uninlined-format-args` in the future.
>
> Cc: stable@...r.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs).
> Cc: Benno Lossin <benno.lossin@...ton.me>
> Link: https://github.com/rust-lang/rust-clippy/pull/14160 [1]
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> ---
> drivers/gpu/nova-core/gpu.rs | 2 +-
> rust/kernel/str.rs | 46 +++++++++++------------
> rust/macros/kunit.rs | 13 ++-----
> rust/macros/module.rs | 19 +++-------
> rust/macros/paste.rs | 2 +-
> rust/pin-init/internal/src/pinned_drop.rs | 3 +-
> 6 files changed, 35 insertions(+), 50 deletions(-)
Reviewed-by: Tamir Duberstein <tamird@...il.com>
Powered by blists - more mailing lists